This is the mail archive of the
archer@sourceware.org
mailing list for the Archer project.
Re: using directive patch
- From: Tom Tromey <tromey at redhat dot com>
- To: Sami Wagiaalla <swagiaal at redhat dot com>
- Cc: Project Archer <archer at sourceware dot org>
- Date: Tue, 16 Sep 2008 10:53:04 -0600
- Subject: Re: using directive patch
- References: <48BED230.1070209@redhat.com> <48C819BF.2040306@redhat.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:
Sami> Here is a second version of the patch after incorporating the
Sami> suggestions and adding a test case.
Looking good.
Sami> + if (imported_name == NULL)
Sami> + {
Sami> + /* C++ imports from std:: DW_TAG_base_type with no DW_AT_name - why? */
Sami> + return;
I'm curious about this comment -- could you say more?
Is this a g++ bug?
Sami> +send_gdb "print a\n"
Sami> +gdb_expect {
Sami> + -re "\\$\[0-9\]* = 1" { pass "print a" }
Sami> + -re ".*$gdb_prompt $" { fail "print a" }
Sami> + timeout { fail "(timeout) print a" }
Sami> +}
You might like gdb_test, which makes it somewhat simpler to write a
send-and-response sequence like this.
Tom