This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
RE: [PATCH] loc2c-runtime: fix compilation failure
- From: "d dot hatayama at fujitsu dot com" <d dot hatayama at fujitsu dot com>
- To: 'Mark Wielaard' <mark at klomp dot org>
- Cc: "'systemtap at sourceware dot org'" <systemtap at sourceware dot org>
- Date: Fri, 7 Feb 2020 10:11:19 +0000
- Subject: RE: [PATCH] loc2c-runtime: fix compilation failure
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eET/QItAYrsRst6Emp96zBqhAra8eWHDvk0wkQrngrI=; b=Cqy8g7mS48RwKFrrxDY6dcU4Ckis/s1UOnukBVojlxBCFmh7L97u36af0F6enOffWpSMHsbc0o2lKtRonI3dAp+3ZI72BnEC8WAPdrZOOIoY/LCwQ7pAUFsTIURayLeZuUQp7tsM25jgc5t5K5I8YlNuemcm8qLbVBvc8IauTe/mkIryeByxHuZOGiI1WrOi6DJcZzUthDweTXkoYcw5TvX/yHgbQEb93N63s7uzC4rfGkmEP9jdbEdg001VKh37Ambw9w/Tl1yE8wPmFJhrlI4D8ytgoSFpizyswMzok/dpC2C29ZSIqhUWego9cboUaUsT3nRFSvHShFiAs4TMUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOc0gSbJOWmLlvyYa+Z87DwE+GLNweyrQZpzKmHzlmxdYiYUSQEzBPIe//Icc8MQADUqY8Dy6B4A7p9PWf1+i0sFaefWMmG4Q1W4NgREM+yW0hZuYG63FJ4XTcUE+i+tGecogTbtqusRmh4wW0jX8uVXm1XyCSC9Kd6K2FLFw8oLI2QaTrOxeSHdeKOkQePAMIrpFRD1RUbjkhlR73MpB39CLrDOZ9voUE2cAbTxBVXvxO1sczdN1QvwYtVzMmfGY7G7uGpuneCcc42xtjpBVO5TgiLO9FQlnn5RaW36qLf7IVobR2ta+pB1RHF7uiLKsiZuhkRM7Cv9y6pPPVRh4w==
- Ironport-sdr: RCUxbGO3q6Ad/94wCQwEE4ZUeLEhbmQQ4vu9K5M/TZ+HReQxxdons2iam1kDy/ikXYC8B016fT sQ7jY8ubkTFxJc8eFrpf445u2AJES/0+iGq9pm6w211uBBUf2KsPLcgRTxBRzckW76UgT8CWeL LRKxZZ/U4rT7l12NgEM/BoEUCFeH3rjrTf04ByG9g3hd6/hhYM6m6dJVCge7+yzgNzQ8JSdUaF y7I99mp9s6QgLLUNXMzVgHe2pFTt/NwXa4/3N/MGg4upPl0xZ8jJM8NvkQA7MP/CgCgqyUbYgZ CeY=
- References: <OSBPR01MB400638DC512D01DAEC0BB583951C0@OSBPR01MB4006.jpnprd01.prod.outlook.com> <20200207095115.GM42691@wildebeest.org>
> -----Original Message-----
> From: Mark Wielaard <mark@klomp.org>
> Sent: Friday, February 7, 2020 6:51 PM
> To: Hatayama, Daisuke/畑山 大輔 <d.hatayama@fujitsu.com>
> Cc: 'systemtap@sourceware.org' <systemtap@sourceware.org>
> Subject: Re: [PATCH] loc2c-runtime: fix compilation failure
>
> Hi,
>
> On Fri, Feb 07, 2020 at 04:07:21AM +0000, d.hatayama@fujitsu.com wrote:
> > I ran into the following compilation failure when I tried to change
> > $return in a return probe for some user-space process:
> > [...]
> > This failure is caused by a typo of the name of an argument variable
> > of macro u_store_register introduced at the commit
> > a03b455bc656216a4829dbad08e630949d944c75.
> > ---
> > runtime/linux/loc2c-runtime.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/runtime/linux/loc2c-runtime.h b/runtime/linux/loc2c-runtime.h
> > index b4a329b..0270fa1 100644
> > --- a/runtime/linux/loc2c-runtime.h
> > +++ b/runtime/linux/loc2c-runtime.h
> > @@ -294,7 +294,7 @@ static void ursl_store64 (const struct usr_regset_lut* lut,unsigned lutsize, in
> > #define uu_store_register(_regs,regno,value) (_stp_is_compat_task() ? ursl_store32(url_i386,
> ARRAY_SIZE(url_i386), EM_386, regno, value) : ursl_store64(url_x86_64, ARRAY_SIZE(url_x86_64), EM_X86_64, regno,
> value))
> >
> > #define u_fetch_register(regno)
> check_fetch_register(c->uregs,regno,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),uu_fetc
> h_register)
> > -#define u_store_register(regno,value)
> check_store_register(c->uregs,regnoo,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,u
> u_store_register)
> > +#define u_store_register(regno,value)
> check_store_register(c->uregs,regno,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,u
> u_store_register)
> >
> > #endif
>
> This looks completely correct. The typo is pretty clear in the
> original commit. I am just surprised we haven't seen this issue
> before since the commit was pushed almost a year ago. What was the
> exact script that showed this issue? We should probably add it as a
> testcase together with the fix.
>
It's enough to reproduce the issue as follows on my system:
# cat ./repro.c
static int f(void)
{
return 0;
}
int main()
{
f();
}
# gcc -g -O0 ./repro.c -o repro
# stap -v -g -e 'probe process("./repro").function("f").return {$return = 1}' -c ./repro
Pass 1: parsed user script and 478 library scripts using 238948virt/80996res/12320shr/68280data kb, in 750usr/240sys/1001real ms.
Pass 2: analyzed script: 1 probe, 1 function, 0 embeds, 0 globals using 240532virt/83832res/13444shr/69864data kb, in 20usr/10sys/48real ms.
Pass 3: translated to C into "/tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.c" using 240664virt/84332res/13696shr/69996data kb, in 170usr/290sys/474real ms.
In file included from /usr/share/systemtap/runtime/linux/runtime.h:217,
from /usr/share/systemtap/runtime/runtime.h:26,
from /tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.c:26:
/tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.c: In function ‘function___private__input___dwarf_tvar_set_return_0’:
/usr/share/systemtap/runtime/linux/loc2c-runtime.h:297:69: error: ‘regnoo’ undeclared (first use in this function); did you mean ‘rep_nop’?
#define u_store_register(regno,value) check_store_register(c->uregs,regnoo,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,uu_store_register)
^~~~~~
/usr/share/systemtap/runtime/linux/loc2c-runtime.h:44:23: note: in definition of macro ‘check_store_register’
if ((regs) == 0 || (regno) < 0 || (regno) > (maxregno)) { \
^~~~~
/tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.c:182:3: note: in expansion of macro ‘u_store_register’
u_store_register(0, l->__tmp0);
^~~~~~~~~~~~~~~~
/usr/share/systemtap/runtime/linux/loc2c-runtime.h:297:69: note: each undeclared identifier is reported only once for each function it appears in
#define u_store_register(regno,value) check_store_register(c->uregs,regnoo,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,uu_store_register)
^~~~~~
/usr/share/systemtap/runtime/linux/loc2c-runtime.h:44:23: note: in definition of macro ‘check_store_register’
if ((regs) == 0 || (regno) < 0 || (regno) > (maxregno)) { \
^~~~~
/tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.c:182:3: note: in expansion of macro ‘u_store_register’
u_store_register(0, l->__tmp0);
^~~~~~~~~~~~~~~~
make[1]: *** [scripts/Makefile.build:312: /tmp/stapDh6s0j/stap_300c9b53758795cc27758f1eaadbf6bd_1183_src.o] Error 1
make: *** [Makefile:1544: _module_/tmp/stapDh6s0j] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compiled C into "stap_300c9b53758795cc27758f1eaadbf6bd_1183.ko" in 45630usr/15450sys/62241real ms.
Pass 4: compilation failed. [man error::pass4]
Thanks.
HATAYAMA, Daisuke