This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Amend fallback comment to work with newer gcc
- From: Mark Wielaard <mark at klomp dot org>
- To: Siddhesh Poyarekar <siddhesh at gotplt dot org>, systemtap at sourceware dot org
- Date: Mon, 27 Jan 2020 09:11:38 +0100
- Subject: Re: [PATCH] Amend fallback comment to work with newer gcc
- References: <20200127072622.345211-1-siddhesh@gotplt.org>
Hi Siddhesh,
On Mon, 2020-01-27 at 12:56 +0530, Siddhesh Poyarekar wrote:
> Newer gcc does not recognize the fallthrough comment due to the text
> following the fallthrough keyword. The "see above" doesn't seem too
> valuable, so this patch drops it to fix the build.
Thanks. Pushed.
I am slightly surprised gcc made this stricter. But this is more
consistent. This was the only place in the code base where we didn't
use the bare /* fallthrough */ comment.
Cheers,
Mark