This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Amend fallback comment to work with newer gcc


Hi Siddhesh,

On Mon, 2020-01-27 at 12:56 +0530, Siddhesh Poyarekar wrote:
> Newer gcc does not recognize the fallthrough comment due to the text
> following the fallthrough keyword.  The "see above" doesn't seem too
> valuable, so this patch drops it to fix the build.

Thanks. Pushed.

I am slightly surprised gcc made this stricter. But this is more
consistent. This was the only place in the code base where we didn't
use the bare /* fallthrough */ comment.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]