This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug translator/19358] netfilter probes are broken on rawhide
- From: "dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Fri, 11 Dec 2015 17:46:26 +0000
- Subject: [Bug translator/19358] netfilter probes are broken on rawhide
- Auto-submitted: auto-generated
- References: <bug-19358-6586 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=19358
--- Comment #1 from David Smith <dsmith at redhat dot com> ---
It looks like the following kernel commit got rid of the 'owner' field:
====
ommit 2ffbceb2b08f8ca0496c54a9ebcd11d25275954e
Author: Florian Westphal <fw@strlen.de>
Date: Tue Oct 13 14:33:26 2015 +0200
netfilter: remove hook owner refcounting
since commit 8405a8fff3f8 ("netfilter: nf_qeueue: Drop queue entries on
nf_unregister_hook") all pending queued entries are discarded.
So we can simply remove all of the owner handling -- when module is
removed it also needs to unregister all its hooks.
====
It looks like the following kernel commit changed the 'hook' field:
====
commit 008027c31d57a22bd80dda5acc95b037634eee0f
Author: Arnd Bergmann <arnd@arndb.de>
Date: Fri Oct 9 20:45:42 2015 +0200
netfilter: turn NF_HOOK into an inline function
A recent change to the dst_output handling caused a new warning
when the call to NF_HOOK() is the only used of a local variable
passed as 'dev', and CONFIG_NETFILTER is disabled:
net/ipv6/ip6_output.c: In function 'ip6_output':
net/ipv6/ip6_output.c:135:21: warning: unused variable 'dev'
[-Wunused-vari\
able]
The reason for this is that the NF_HOOK macro in this case does
not reference the variable at all, and the call to dev_net(dev)
got removed from the ip6_output function. To avoid that warning now
and in the future, this changes the macro into an equivalent
inline function, which tells the compiler that the variable is
passed correctly but still unused.
The dn_forward function apparently had the same problem in
the past and added a local workaround that no longer works
with the inline function. In order to avoid a regression, we
have to also remove the #ifdef from decnet in the same patch.
====
It looks like these changes first appeared in kernel v4.4-rc1.
--
You are receiving this mail because:
You are the assignee for the bug.