This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/4] add case for probe timer
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: Zhou, Wenjian/åæå <zhouwj-fnst at cn dot fujitsu dot com>
- Cc: David Smith <dsmith at redhat dot com>, systemtap at sourceware dot org
- Date: Mon, 30 Nov 2015 17:37:17 -0500
- Subject: Re: [PATCH 1/4] add case for probe timer
- Authentication-results: sourceware.org; auth=none
- References: <1447406704-14585-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <5656C888 dot 3080503 at cn dot fujitsu dot com>
Hi -
> I try to send essential cases, but I can't make sure all of the cases
> are needed.
> So I need your help. If you have time, you can tell me why the cases have
> no sense, or you can just let me know which are meaningless.
The general idea is to check for duplication. If you are testing a
language control flow construct, see if there is already ample usage
of that same construct already in the testsuite. If you are testing a
probe point, see if that same point, or a close member of the family,
is already well-represented. The other idea is that for new tests for
fairly old/static parts of code are probably not worth much effort,
that code having been proven over time.
For example, the cond_compile test is thoroughly covered already by
other stuff; check all the %( %) preprocessor usage in the tapsets as
well as other testsuite script. The semko ones don't look too
duplicative, but also don't relate to recently-changed code. I
wouldn't oppose those going into the testsuite, but the slight extra
cost of making the test runs longer counts slightly against them.
- FChE