This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] add testcases for variables scope
- From: David Smith <dsmith at redhat dot com>
- To: Zhou, Wenjian/åæå <zhouwj-fnst at cn dot fujitsu dot com>
- Cc: systemtap at sourceware dot org
- Date: Fri, 6 Nov 2015 12:47:13 -0600
- Subject: Re: [PATCH] add testcases for variables scope
- Authentication-results: sourceware.org; auth=none
- References: <1446712067-24880-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <563B3744 dot 6060501 at cn dot fujitsu dot com> <563B8A00 dot 8010407 at redhat dot com> <563BFDB9 dot 5050601 at cn dot fujitsu dot com>
On 11/05/2015 07:09 PM, "Zhou, Wenjian/åæå" wrote:
> On 11/06/2015 12:55 AM, David Smith wrote:
>> ... stuff deleted ...
>>
>>> I think there are two ways to fix it, if it needs to be fixed.
>>> 1,
>>> adjust the function stap_run
>>>
>>> 2,
>>> change the way of printing "systemtap test success" (likes the
>>> implementation in this patch)
>>>
>>> I prefer the second, for it won't introduce some other errors.
>>
>> You way #2 above would have worked fine. I fixed it with a 3rd solution,
>> just changing the expected result string to be 2 copies of the
>> 'all_pass_string':
>>
>> <https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commit;h=0d7d53dd805f636278858651a649d57fb87ba6c8>
>>
>>
>> Thanks for finding this.
>
> The testcase "if" is just an example.
> There are still many other testcases having this problem...
> Should I fix it?
Yes, it would be great if this was fixed. The first step would be to get
a list of all the testcases with the problem. Then we'd fix it using
either method #2 or #3.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)