This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/16616] the 'servername' convenience variable returned by the rpc tapset can be NULL
- From: "dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Tue, 25 Feb 2014 19:27:49 +0000
- Subject: [Bug tapsets/16616] the 'servername' convenience variable returned by the rpc tapset can be NULL
- Auto-submitted: auto-generated
- References: <bug-16616-6586 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16616
David Smith <dsmith at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 1f09b39. This commit uses the new '__rpc_format_servername'
function to properly generate the 'servername' variable.
Unfortunately, I couldn't use "%#1p" to format the NULL pointer. GCC doesn't
allow '#' to be used with '%p' - you get the following error:
error: '#' flag used with â%pâ gnu_printf format [-Werror=format=]
So, I ended up just removing our hardcoded '0x' (since we have lots of other
places we print pointers without '0x') and changed the format from '%p' to
'%1p'.
--
You are receiving this mail because:
You are the assignee for the bug.