Re: vfs tapset compilation error.

[Mark Wielaard <mjw at redhat dot com>]

On Tue, 2011-01-25 at 23:44 +0100, Mark Wielaard wrote:
> On Tue, 2011-01-25 at 23:58 +0200, Daniel Fishman wrote:
> > On Tue, 25 Jan 2011 13:04:29 +0100, Mark Wielaard <mjw@redhat.com> wrote:
> > 
> > >Just in case, could you try this hack to make sure the file names the
> > >parse sees are always canonical?
> > 
> > The problem occurs even if there is no double slashes. The additional
> > slash is due to the fact that XDG_DATA_DIRS was set to /usr/share/
> > (see my other reply), but the problem occurs when XDG_DATA_DIRS is 
> > set to /usr/share and there are no double slashes.
> 
> Aha, thanks. That makes sense. I am testing the following patch, which
> should make sure all paths added to the include path are unique.
> 
> If you could also try it, that would be help.

Although it seems my patch works, and we do scan fewer files if an
include dir happens to be included multiple times, I am still a little
confused how this can happen. This issue should already have been dealt
with through: http://sourceware.org/bugzilla/show_bug.cgi?id=11949

Do you have the following commit included in your build?

commit ad7c8e4393af112099a0ab3c54e3b49056ef6289
Author: Frank Ch. Eigler <fche@elastic.org>
Date:   Thu Aug 26 18:30:28 2010 -0400

    PR11949: duplicate-eliminate tapset files
    
    * main.cxx (passes_0_4): Bypass tapset script files already parsed,
      based upon device/inode matching.

Thanks,

Mark