This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: uprobes and empty functions


On Mon, 2010-11-01 at 14:46 -0700, Josh Stone wrote:
> On 11/01/2010 01:14 PM, Josh Stone wrote:
> > Attached.  I'm refusing to probe any of those "special" instructions if
> > they have a prefix, with the sole exception of "rep ret" because we can
> > make sense of that.  (I only diffed uprobes2 this time, but of course
> > the others need the same fix...)
> 
> Here's another iteration.  This time I addressed the TODO that
> uprobe_post_ssout should use flags, which makes the code a bit nicer.
> Reviews welcome...
> 
> Thanks,
> Josh

Thanks.  The only problem I see is that if setup_uprobe_post_ssout()
rejects the instruction, you need to report that via printk().

Jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]