This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug translator/11353] elide side-effect-free probes
- From: "chwang at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sources dot redhat dot com
- Date: 8 Mar 2010 22:01:28 -0000
- Subject: [Bug translator/11353] elide side-effect-free probes
- References: <20100307135957.11353.fche@redhat.com>
- Reply-to: sourceware-bugzilla at sourceware dot org
------- Additional Comments From chwang at redhat dot com 2010-03-08 22:01 -------
(In reply to comment #3)
> jistone is right, casting without a full understanding of the issues
> is a recipe for trouble.
>
> FWIW, I would probably preserve the warning about entirely elided probes
> (and suppress the messages as usual with stap -w).
Sorry about that, I had thought p->body would still be castable at that point
since it didn't look like there were any intervening steps that would change it.
The patch also misses the majority of the cases (i.e. probes that are optimized
out), and definitely breaks a bunch of tests so not too useful :(.
So the probes should be removed in semantic_pass_opt4 (where the warning is
currently thrown)? Also, does 'removing them entirely' entail removing them from
systemtap_session.probes? I seem to have somehow convinced myself that it does :/
--
http://sourceware.org/bugzilla/show_bug.cgi?id=11353
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.