This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 02/02] Backport recently added probes to RHEL5(U5)
On 03/04/2010 02:50 PM, David Smith wrote:
> On 03/04/2010 10:53 AM, Steve Dickson wrote:
>> commit 35f22bd95cea2fb75573a27282f2a5edea84f2d7
>> Author: Steve Dickson <steved@redhat.com>
>> Date: Thu Mar 4 09:18:47 2010 -0500
>>
>> Backport recently added probes to RHEL5(U5)
>>
>> Ensured the recent additions of v4 probes and supporting
>> routines worked or at least don't break with RHEL5 U5 kernel.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> Thanks for the work here. But, as much as possible, we're trying to
> move away from kernel version checks. (Yes, I know there are lots of
> kernel version checks in the tapsets, but we're in the process of trying
> to remove as many as possible. So, "do as we say" here, not "do as we
> currently do".)
Understood....
>
> To do this, you'll make those functions that might not exist optional
> (using '?'). For example, instead of:
>
> ====
> probe nfsd.proc.lookup =
> %( kernel_v >= "2.6.25" %?
> nfsd.proc4.lookup,
> %)
> nfsd.proc3.lookup,
> nfsd.proc2.lookup
> ====
>
> You'd have:
>
> ====
> probe nfsd.proc.lookup =
> nfsd.proc4.lookup ?,
> nfsd.proc3.lookup,
> nfsd.proc2.lookup
> ====
>
> You'd also remove the kernel version check around the
> 'nfsd.proc4.lookup' probe itself.
Sounds like a plan... I'll post a patch making those changes...
>
> I believe this should allow you to remove the majority of the kernel
> version checks you added in this patch. (If this doesn't work, let me
> know and let's see if we can't figure another way around it.)
Will do..
steved.