This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 04/10] Updated nfsd.proc.write probes
- From: David Smith <dsmith at redhat dot com>
- To: Steve Dickson <SteveD at redhat dot com>
- Cc: Systemtap Mailing list <systemtap at sources dot redhat dot com>
- Date: Fri, 26 Feb 2010 14:30:00 -0600
- Subject: Re: [PATCH 04/10] Updated nfsd.proc.write probes
- References: <4B86F6E4.8020408@RedHat.com> <4B86F814.4060209@RedHat.com>
On 02/25/2010 04:22 PM, Steve Dickson wrote:
> commit 1a3da2a334dc24b2efb1d7f165fe81af2261524f
> Author: Steve Dickson <steved@redhat.com>
> Date: Tue Feb 23 11:48:15 2010 -0500
>
> Updated nfsd.proc.write probes
>
> Converted the nfsd.proc.write probes to used
> the @cast() mechanism.
>
> Created the nfsd.proc4.write probes
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> diff --git a/tapset/nfsd.stp b/tapset/nfsd.stp
> index 84f1c56..b501773 100644
> --- a/tapset/nfsd.stp
> +++ b/tapset/nfsd.stp
... reasonable looking changes deleted ...
> +probe nfsd.proc4.commit = kernel.function("nfsd4_commit") !,
> + module("nfsd").function("nfsd4_commit") ?
> +{
> + client_ip = addr_from_rqst($rqstp)
> + proto = $rqstp->rq_prot
> + version = 4
> + fh = & @cast($cstate, "nfsd4_compound_state", "kernel:nfsd")->current_fh
> + count = $commit->co_offset
> + offset = $commit->co_offset
Is setting both 'count' and 'offset' from the same value correct?
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)