This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v5 06/10] kprobes/x86: Cleanup save/restore registers
- From: Frederic Weisbecker <fweisbec at gmail dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: Masami Hiramatsu <mhiramat at redhat dot com>, Ingo Molnar <mingo at elte dot hu>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, Steven Rostedt <rostedt at goodmis dot org>, "H. Peter Anvin" <hpa at zytor dot com>, Anders Kaseorg <andersk at ksplice dot com>, Tim Abbott <tabbott at ksplice dot com>, Andi Kleen <andi at firstfloor dot org>, Jason Baron <jbaron at redhat dot com>, Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- Date: Tue, 24 Nov 2009 21:20:00 +0100
- Subject: Re: [PATCH -tip v5 06/10] kprobes/x86: Cleanup save/restore registers
- References: <20091123232115.22071.71558.stgit@dhcp-100-2-132.bos.redhat.com> <20091123232204.22071.60562.stgit@dhcp-100-2-132.bos.redhat.com> <20091124025115.GB6752@nowhere> <y0mtywkx76f.fsf@fche.csb>
On Tue, Nov 24, 2009 at 10:40:24AM -0500, Frank Ch. Eigler wrote:
> Frederic Weisbecker <fweisbec@gmail.com> writes:
>
> > [...]
> >> +#define SAVE_REGS_STRING \
> >> +#define RESTORE_REGS_STRING \
> >
> > BTW, do you really need to push/pop every registers
> > before/after calling a probe handler?
>
> It's part of the definition of a kprobe, that a populated
> pt_regs* value is passed. Clients can rely on that in order
> to access registers etc.
>
> - FChE
Yeah I made a confusion. Sorry.