This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip tracing/kprobes 0/9] tracing/kprobes, perf: perf probe and kprobe-tracer bugfixes
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Frederic Weisbecker <fweisbec at gmail dot com>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, Thomas Gleixner <tglx at linutronix dot de>, Arnaldo Carvalho de Melo <acme at redhat dot com>, Mike Galbraith <efault at gmx dot de>, Paul Mackerras <paulus at samba dot org>, Peter Zijlstra <a dot p dot zijlstra at chello dot nl>, Christoph Hellwig <hch at infradead dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, "Frank Ch. Eigler" <fche at redhat dot com>, "H. Peter Anvin" <hpa at zytor dot com>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Sat, 17 Oct 2009 10:02:03 +0200
- Subject: Re: [PATCH -tip tracing/kprobes 0/9] tracing/kprobes, perf: perf probe and kprobe-tracer bugfixes
- References: <20091017000711.16556.69935.stgit@dhcp-100-2-132.bos.redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Hi Ingo and Frederic,
>
> Here are the bugfix and update (mostly cleanup) patches for
> previous patchset.
>
> > I hope it's part of the last family of instruction set we
> > are missing.
>
> I added missing SSE opcodes and 3DNow! support too.
> However, near future, x86 decoder may need AVX support.
> (AFAIK, currently, there are no code using it.)
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (9):
> perf: Add perf-probe document
> perf: Add DIE_IF() macro for error checking
> perf: Use eprintf() for debug messages in perf-probe
> perf: Use die() for error cases in perf-probe
> perf: Check libdwarf APIs for perf probe
> x86: Add AMD prefetch and 3DNow! opcodes to opcode map
> x86: Add MMX/SSE opcode groups to opcode map
> tracing/kprobes: Add failure messages for debugging
> tracing/kprobes: Update kprobe-tracer selftest against new syntax
>
>
> arch/x86/lib/x86-opcode-map.txt | 23 ++++-
> kernel/trace/trace_kprobe.c | 39 ++++++--
> tools/perf/Documentation/perf-probe.txt | 48 ++++++++++
> tools/perf/Makefile | 5 +
> tools/perf/builtin-probe.c | 70 ++++++---------
> tools/perf/command-list.txt | 1
> tools/perf/util/probe-finder.c | 149 ++++++++++++++-----------------
> tools/perf/util/probe-finder.h | 17 ----
> tools/perf/util/util.h | 9 ++
> 9 files changed, 206 insertions(+), 155 deletions(-)
> create mode 100644 tools/perf/Documentation/perf-probe.txt
Looks really nice, thanks Masami!
Note, i've created a new topic tree for this work: tip:perf/probes, and
have put all the commits there - since i expect most of the
enabling/completion work for this feature to happen on the perf events
side.
I also merged this tree upto v2.6.32-rc5 and resolved a conflict with
recent tracing fixes. Please base future patches on this new tree.
Thanks,
Ingo