This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supports arguments
- From: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, systemtap-ml <systemtap at sources dot redhat dot com>, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, Andrew Morton <akpm at linux-foundation dot org>
- Date: Mon, 30 Mar 2009 21:06:56 +0530
- Subject: Re: [PATCH -tip 3/4 V3] tracing: kprobe-tracer plugin supports arguments
- References: <49CC08D2.30608@redhat.com> <20090330045813.GB6411@in.ibm.com> <49D0E600.7050204@redhat.com>
- Reply-to: ananth at in dot ibm dot com
On Mon, Mar 30, 2009 at 11:32:16AM -0400, Masami Hiramatsu wrote:
> Ananth N Mavinakayanahalli wrote:
> > On Thu, Mar 26, 2009 at 06:59:30PM -0400, Masami Hiramatsu wrote:
> >
> >> +/* TODO: Move these functions to arch/XXX/include/asm/debugger.h */
> >> +
> >
> > Maybe arch/xxx/lib/<>.c too?
> >
> > I know its on your list of TODOs but I'd prefer to have an
> > arch_fetch_func_args() or somesuch in arch specific code, to start with.
> > It is trivial to implement the argument extraction code on certain
> > architectures and such a helper would be great.
>
> Hmm, I think fetch_* functions are more general framework, but
> it's true that some of their implementation depend on architecture.
> Thus, I'd prefer to separate some of basic implementaions(get_stack_nth,
> get_argument_nth) from fetch_* and move it to arch/xxx/include/asm/ptrace.h,
> because there are similar inline functions.
> What would you think about this?
I don't really have an opinion on the nomenclature as long as there is a
clear arch specific callout that doesn't need to touch arch agnostic
files.
Ananth