This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH][bugfix] kprobes: fix module compilation error with CONFIG_KPROBES=n
- From: Andrew Morton <akpm at linux-foundation dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, David Miller <davem at davemloft dot net>, LKML <linux-kernel at vger dot kernel dot org>, systemtap-ml <systemtap at sources dot redhat dot com>
- Date: Wed, 14 Jan 2009 00:32:34 -0800
- Subject: Re: [PATCH][bugfix] kprobes: fix module compilation error with CONFIG_KPROBES=n
- References: <49628849.1000706@redhat.com>
On Mon, 05 Jan 2009 17:23:05 -0500 Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Define kprobes related data structures even if CONFIG_KPROBES is not set.
> This fixes compilation errors which occur if CONFIG_KPROBES is not set, in
> kprobe using modules.
>
> Reviewed-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> include/linux/kprobes.h | 45 +++++++++++++++++++++++----------------------
> 1 file changed, 23 insertions(+), 22 deletions(-)
>
> Index: 2.6.28/include/linux/kprobes.h
> ===================================================================
> --- 2.6.28.orig/include/linux/kprobes.h
> +++ 2.6.28/include/linux/kprobes.h
> @@ -37,9 +37,9 @@
> #include <linux/spinlock.h>
> #include <linux/rcupdate.h>
> #include <linux/mutex.h>
> +#include <asm/kprobes.h>
>
> #ifdef CONFIG_KPROBES
> -#include <asm/kprobes.h>
>
The above change breaks alpha, and any other architecture which has no
asm/kprobes.h.
I undid that change, but maybe that rebroke things?