This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-517-g63ef59c
- From: Mark Wielaard <mjw at redhat dot com>
- To: systemtap at sourceware dot org
- Cc: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- Date: Thu, 27 Nov 2008 14:55:42 +0100
- Subject: Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-517-g63ef59c
- References: <20081121093406.30499.qmail@sourceware.org>
Hi Srikar,
On Fri, 2008-11-21 at 09:34 +0000, srikar@sourceware.org wrote:
> commit 63ef59c300b42bfda9fe53549f24ce09fcb360b6
> Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Date: Fri Nov 21 15:03:53 2008 +0530
>
> Handle a clone case which should behave like fork
This fix is correct. But we did have a testcase that depended on the old
behavior. Please do run make [install]check whenever possible to catch
such things (I do admit that the syscall.exp test takes ages though...)
Fixed testcase as attached.
Cheers,
Mark
diff --git a/testsuite/systemtap.syscall/ChangeLog b/testsuite/systemtap.syscall/ChangeLog
index 7cb97df..e3a1f8d 100644
--- a/testsuite/systemtap.syscall/ChangeLog
+++ b/testsuite/systemtap.syscall/ChangeLog
@@ -1,3 +1,8 @@
+2008-11-27 Mark Wielaard <mjw@redhat.com>
+
+ * forkwait.c: clone (CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD)
+ is just fork ().
+
2008-10-04 Mark Wielaard <mjw@redhat.com>
* access.c: sys_access() calls through to sys_faccessat().
diff --git a/testsuite/systemtap.syscall/forkwait.c b/testsuite/systemtap.syscall/forkwait.c
index ffc9870..bf7516f 100644
--- a/testsuite/systemtap.syscall/forkwait.c
+++ b/testsuite/systemtap.syscall/forkwait.c
@@ -12,7 +12,7 @@ int main ()
int status;
child = fork();
- // clone (CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD) = NNNN
+ // fork () = NNNN
if (!child) {
int i = 0xfffff;
while (i > 0) i--;