This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28

From: Masami Hiramatsu <mhiramat at redhat dot com>
To: Eduardo Habkost <ehabkost at redhat dot com>
Cc: systemtap at sourceware dot org
Date: Wed, 19 Nov 2008 12:53:05 -0500
Subject: Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28
References: <1227103412-9128-1-git-send-email-ehabkost@redhat.com> <492425D6.1060502@redhat.com> <20081119152444.GW4481@blackpad>

Eduardo Habkost wrote:
> On Wed, Nov 19, 2008 at 09:42:30AM -0500, Masami Hiramatsu wrote:
>> Hi Eduardo,
>>
>> I think you'd better add new autoconf-foreachcpu.c for checking existence of
>> for_each_cpu_possible() macro, instead of checking KERNEL_VERSION.
> 
> Why? for_each_cpu_possible() exists since 2.6.17. The original
> for_each_cpu() fix didn't use an autoconf-*.c check.

Oh, in that case, it's ok for me.

Thank you,
-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com

References:
- [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28
  - From: Eduardo Habkost
- Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28
  - From: Masami Hiramatsu
- Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28
  - From: Eduardo Habkost

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]