This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 2/7] kprobes: Add kprobe_insn_mutex and cleanup arch_remove_kprobe()
- From: Andrew Morton <akpm at linux-foundation dot org>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: ananth at in dot ibm dot com, jkenisto at us dot ibm dot com, davem at davemloft dot net, linux-kernel at vger dot kernel dot org, systemtap at sources dot redhat dot com, rusty at rustcorp dot com dot au
- Date: Thu, 13 Nov 2008 16:21:28 -0800
- Subject: Re: [PATCH 2/7] kprobes: Add kprobe_insn_mutex and cleanup arch_remove_kprobe()
- References: <4919F175.2050009@redhat.com>
On Tue, 11 Nov 2008 15:56:21 -0500
Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Add kprobe_insn_mutex for protecting kprobe_insn_pages hlist, and remove
> kprobe_mutex from architecture dependent code.
>
> This allows us to call arch_remove_kprobe() (and free_insn_slot) while holding
> kprobe_mutex.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> arch/arm/kernel/kprobes.c | 2 --
> arch/ia64/kernel/kprobes.c | 8 +++++---
> arch/powerpc/kernel/kprobes.c | 7 ++++---
> arch/s390/kernel/kprobes.c | 7 ++++---
> arch/x86/kernel/kprobes.c | 7 ++++---
> include/linux/kprobes.h | 1 -
> kernel/kprobes.c | 25 +++++++++++++++++++++----
For some reasons sparc64 never had this mutex. You've checked that
sparc64 will be OK after this change?