This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[PATCH] markers: fix missing modpost entry in Module.markers
- From: Lai Jiangshan <laijs at cn dot fujitsu dot com>
- To: Andrew Morton <akpm at linux-foundation dot org>, Greg KH <gregkh at suse dot de>
- Cc: stable at kernel dot org, Linux Kernel Mailing List <linux-kernel at vger dot kernel dot org>, Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>, Roland McGrath <roland at redhat dot com>, Wenji Huang <wenji dot huang at oracle dot com>, Takashi Nishiie <t-nishiie at np dot css dot fujitsu dot com>, systemtap at sourceware dot org
- Date: Tue, 07 Oct 2008 14:35:23 +0800
- Subject: [PATCH] markers: fix missing modpost entry in Module.markers
commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
marker points compiled in vmlinux are missing in Module.markers.
# cat Module.markers
subsystem_event samples/markers/marker-example integer %d string %s
subsystem_eventb samples/markers/marker-example
# stap -e 'probe kernel.mark("core_marker_format"){} '
semantic error: no match while resolving probe point kernel.mark("core_marker_format")
semantic error: no probes found
Pass 2: analysis failed. Try again with more '-v' (verbose) options.
This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
Other parts have fixed duplicate modpost entry bug.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 418cd7d..3509142 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
mod->skip = 1;
}
- if (!mod->skip)
- add_marker(mod, marker, fmt);
+ add_marker(mod, marker, fmt);
}
return;
fail: