This is the mail archive of the mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC -mm][PATCH 0/6] kprobes x86 code unification and boosters (review part 2)

FYI, here are review comments I sent privately to Masami yesterday.  (I
was in a hurry and didn't cc everybody.)  He has already addressed them.

Patch #5:
+#define C ,
This is a creative solution to the problem of test_bit() wanting
an unsigned long* arg.  It may be a little TOO creative for some
reviewers.  If so, remember that you can make the tables all u64
or u32, and just add (const unsigned long*) casts to the test_bit()

In kprobes_64.c...

+#undef  C
s/  / /

+ * Interrupts are disabled on entry as trap3 is an interrupt gate and
+ * remain disabled thorough out this function.
+ */
+static int __kprobes kprobe_handler(struct pt_regs *regs)
I assume you're confident about this.  If not, verify with somebody
like Andi Kleen.  I tried to verify this by sifting through traps_64.c
and desc_64.c and the AMD manuals, but gave up after a while.

Patch #6:
Regarding the historical comments in kprobes.c and kprobes.h...

1. What's the current policy regarding such comments?  Should they just
be removed?  If not...

2. Seems like historical notes for kprobe boosters and kretprobe
should be added.  (Modesty should not obscure history. :-))

3. You could probably remove the historical comments from kprobes.h,
and/or add a ref to the (more nearly complete) history in kprobes.c.

4. Since each file reflects both i386 and x86_64 now, you need to
clarify some comments:

  a. In kprobes.h, the 2004-Oct comment should end with something
  like "x86_64 adopted from i386".

  b. In kprobes.c, the 2005-May comment about Rusty Lynch should say
  "Added x86_64 function-return probes".  Also, it should follow the
  other 2005-May comment, since we implemented i386 first.

5. s/kenistoj/jkenisto/

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]