This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] For memory access error when calling _stp_sockaddr_str with addrlen set to 0


"Zhaolei" <zhaolei@cn.fujitsu.com> writes:

> I found a memory access error in aux_syscall.stp's _stp_sockaddr_str
> function.

Thanks.

> [...]  Also, I think the buf's length should be considered when
> using it.  If no objection, I will commit the following patch:

Looks good, except that I suggest using sizeof()-based expressions
instead of literal numbers for the length comparisons, if possible.


- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]