This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix bug of syscall.lseek's offset



Sorry, this patch has been checked in 13 days ago. I found that just now.

I'm sorry I bothered you.

Frank Ch. Eigler wrote:
Lai Jiangshan <laijs@cn.fujitsu.com> writes:

How about the following patch? Is there any problem?
[...]
probe syscall.lseek = kernel.function("sys_lseek") {
[...]
-    offset = __int32($offset)
+    offset = $offset

This looks good to me, as long as it tests fine on some 32-bit hosts. We had some $variable width/signedness problems that were fixed a few months ago in bug #3331. It may have fixed the need for the __int32 kludge too.

- FChE





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]