This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Set buf as address type in tapset's syslog probe

From: fche at redhat dot com (Frank Ch. Eigler)
To: "Zhaolei" <zhaolei at cn dot fujitsu dot com>
Cc: <systemtap at sourceware dot org>
Date: Wed, 29 Aug 2007 12:25:38 -0400
Subject: Re: [patch] Set buf as address type in tapset's syslog probe
References: <46CA9241.2010008@cn.fujitsu.com> <022701c7ea16$acd3a4c0$85697c0a@guest004>

"Zhaolei" <zhaolei@cn.fujitsu.com> writes:

> [...]  In probe syslog in tapset, buf is set as string type in
> argstr.  But buf is always used for storing returned data in
> syslog().  So i think it is better to set it to address type(%p).
> [...]

You're right.  The confusion probably arises from syslog(3), which
*sends* message strings to the syslog daemon.  syslog(2) *reads* them
from the kernel system log.  The syslog(2) man page says as much.

- FChE

References:
- [patch] Fix bug of syscall.lseek's offset
  - From: Lai Jiangshan
- [patch] Set buf as address type in tapset's syslog probe
  - From: Zhaolei

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]