This is the mail archive of the mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Systemtap test results for systemtap-20070317 on s390

David Smith wrote:

David Wilder wrote:

I fixed my kprobe but that was causing the test not to run.

I took a brief look at your results and saw this one:

Running /home/wilder/stap/src/testsuite/systemtap.stress/conversions.exp ...
ERROR: tcl error sourcing /home/wilder/stap/src/testsuite/systemtap.stress/conversions.exp.
ERROR: can't use non-numeric string as operand of "&&"
while executing
"if {[istarget s390x-*-*] && {$value == 0}} { set value 0x7777777777 }"
("foreach" body line 5)
invoked from within

That's a test case error (the {} shouldn't be surrounding the $value test). I've fixed this.

It works now. Thanks.

BTW: I must have had a brain cramp, when I suggested testing 0x7777777777. I must have been thinking in octal or something:) I should have said 0xffffffff. But that case is tested anyway so the test is fine the way it is. Thanks for fixing it.

David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]