This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Kprobes Support for ARM arch

From: "Abhishek Sagar" <sagar dot abhishek at gmail dot com>
To: "rsmadhvesh at vsnl dot net" <rsmadhvesh at vsnl dot net>
Cc: systemtap at sources dot redhat dot com, madhvesh dot s at ap dot sony dot com, satish dot v at ap dot sony dot com
Date: Thu, 18 Jan 2007 21:13:12 +0530
Subject: Re: Kprobes Support for ARM arch
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=V4FTGVi0JFwB8iVu41vOZ8AvmnRjnM160etJ7MyFLG/5MGb/HKFQEJnCHuWcEvkDoIpwac2mYDH7rlDeRdmqsJYidbj3z+0BQ5CiUOKU65hdfclKN3DUIzPH4RaitWuk4xaZG+kBhA9jsZlGTJEdXo0/2TXYp5Ho8gZKlrANZDw=
References: <e3fee14ecb18.45a696cf@vsnl.net> <20070112053157.GA7437@in.ibm.com> <e272aae413a24.45af7b73@vsnl.net> <e379db5a15cac.45af7e6e@vsnl.net>

> The attached patch addresses the branch instructions
> check for ARM kprobes last week release and avoids
> unexpected crash when probe is placed for branch
> type instructions. If any one finds issues, please let
> me know.
>
> Regards
> Madhvesh


I would be a good defensive check to include bxj in the first switch
case. The goto's can also be replaces with returns in case you only
intend to do a 'return ret' in the 'kprobe_out' label.

- Abhishek Sagar

Follow-Ups:
- Re: Kprobes Support for ARM arch
  - From: Abhishek Sagar

References:
- Kprobes Support for ARM arch
  - From: rsmadhvesh
- Re: Kprobes Support for ARM arch
  - From: Ananth N Mavinakayanahalli
- Re: Kprobes Support for ARM arch
  - From: rsmadhvesh
- Re: Kprobes Support for ARM arch
  - From: rsmadhvesh

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]