This is the mail archive of the mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Preemption-safe kprobe-booster(Re: [PATCH]kprobe booster for IA64)

On Thu, Jul 13, 2006 at 08:25:17PM +0900, Masami Hiramatsu wrote:
> Hi, Anil
> Thank you for precise advice.
> Keshavamurthy Anil S wrote:
> > On Wed, Jul 12, 2006 at 03:22:37PM +0900, Masami Hiramatsu wrote:
> Now, we are searching for other good solutions against this problem.
> Anyway, I'd like to disable booster when CONFIG_PREEMPT is defined
> until this problem is solved. I attached the patch to this mail.
> Please review it.

--Comment here please 
 /* Booster probe is not support for preemptable kernel */
   ^^^^^^ Should be #ifndef
> +	if (p->ainsn.boostable == 1 && !p->post_handler){
>  		/* Boost up -- we can execute copied instructions directly */
>  		reset_current_kprobe();
>  		regs->eip = (unsigned long)p->ainsn.insn;
>  		preempt_enable_no_resched();
>  		return 1;
>  	}
> +#endif
>  	prepare_singlestep(p, regs);
>  	kcb->kprobe_status = KPROBE_HIT_SS;
>  	return 1;

Also you may want to do the same thing for kretprobe booster.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]