This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: kprobe fault handling


Hi -

> > As mentioned several times, this runtime routine "_stp_copy_from_user"
> > is not safe, and should be rewritten or removed.
> 
> Yes, you always say this. Please tell us why that is so.

Always for the same reason: because it invokes functions that can
might sleep (and are in fact documented as such).  Don't be fooled by
the clever trick of bypassing the "might_sleep" warning using that
"...._inatomic" lower level call.

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]