This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH]Systemtap IA64 Runtime support
anil.s.keshavamurthy wrote:
> [...]
> --- src.orig/runtime/copy.c
> +++ src/runtime/copy.c
> @@ -1,3 +1,12 @@
> +/* Copy from user space functions
> + * Copyright (C) 2005 Intel Corporation.
> + *
> + * This file is part of systemtap, and is free software. You can
> + * redistribute it and/or modify it under the terms of the GNU General
> + * Public License (GPL); either version 2, or (at your option) any
> + * later version.
> + */
(There seems to have been an oversight in attaching Red Hat copyright
notices to some of the runtime files.)
> #elif defined (__powerpc64__)
> #define __stp_strncpy_from_user(dst,src,count,res) \
> do { res = __strncpy_from_user(dst, src, count); } while(0)
> +#elif defined (__ia64__)
> +#define __stp_strncpy_from_user(dst,src,count,res) \
> + do { res = __strncpy_from_user(dst, src, count); } while(0)
> #endif
Why not "#elif defined (__powerpc64__) || defined (__ia64__)?
> [...]
> @@ -25,10 +34,9 @@ String _stp_symbol_sprint (String str, u
> - _stp_sprintf (str, "0x%lx", address);
> -
> if (name) {
> - if (modname)
> + _stp_sprintf (str, "0x%lx", address);
Why is this part now conditional on <name> ?
> [...]
> + // In IA64 platform function probe point is set at its
> + // entry point rather than prologue end pointer, and in
> + // IA64 prologue end point also is not computed in such way
I probably missed the discussion, but why exactly is this? Are all
the parameters available at the debuginfo-identified location list
right at this entry address?
> [...]
> - s.op->newline() << "#define MAXSTRINGLEN 128";
> + s.op->newline() << "#define MAXSTRINGLEN 256";
Why?
- FChE