This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: RFC: major runtime map changes
- From: Martin Hunt <hunt at redhat dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: "systemtap at sources dot redhat dot com" <systemtap at sources dot redhat dot com>
- Date: Thu, 20 Oct 2005 10:54:10 -0700
- Subject: Re: RFC: major runtime map changes
- Organization: Red Hat Inc
- References: <1129761252.4284.30.camel@monkey> <y0m7jc82npw.fsf@toenail.toronto.redhat.com>
While we're talking about changes to maps, what should happen when an
_stp_map_set_xxx() fails due to lack of space? Currently this does not
happen because maps are set to wrap by default. So the oldest entry in
the map is cleared and reused. There is a BZ asking for that to be
changed.
So which of the following should happen?
1. wraps and returns an error code
2. fails (does not store value) and returns error code
3. increments a "drops" counter for the map
4. does stp_warn()