Re: [PATCH v2] Add i386 and x86_64 fenv support from Cygwin.

[Corinna Vinschen <vinschen at redhat dot com>]

On Sep  4 12:14, Eric Blake wrote:
> On 9/4/19 11:58 AM, Joel Sherrill wrote:
> 
> >>>>> +++ b/newlib/libc/machine/x86_64/sys/fenv.h
> >>>>> @@ -0,0 +1,170 @@
> >>>>> +/*
> >>>>> + * SPDX-License-Identifier: BSD-2-Clause
> >>>>> + *
> >>>>> + * Copyright (c) 2010-2019 Red Hat, Inc.
> >>>>> + * All rights reserved.
> >>>>> + *
> >>>>> + * Redistribution and use in source and binary forms, with or without
> >>>>> + * modification, are permitted provided that the following conditions
> >>>>> + * are met:
> >>>>> + * 1. Redistributions of source code must retain the above copyright
> >>>>> + *    notice, this list of conditions and the following disclaimer.
> >>>>> + * 2. Redistributions in binary form must reproduce the above copyright
> >>>>> + *    notice, this list of conditions and the following disclaimer in the
> >>>>> + *    documentation and/or other materials provided with the distribution.
> >>>>> + *
> >>>>> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
> >>>>> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> >>>>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> >>>>> + * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
> >>>>> + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> >>>>> + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> >>>>> + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> >>>>> + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> 
> >> I didn't actually check newlib files, but SPDX + written out license
> >> only makes marginal sense.  So, let's start with *these* files to do it
> >> right, please.
> > 
> > SPDX line plus an organization copyright? Like this:
> > 
> > /*
> >  * SPDX-License-Identifier: BSD-2-Clause
> >  *
> >  * Copyright (c) 2010-2019 Red Hat, Inc.
> >  * All rights reserved.
> >  */
> > 
> 
> It sounds funny to claim a license that grants rights to users, but yet
> states "All rights reserved" that sounds like you are NOT granting
> rights to others.  These days, it has lost all legal significance, and
> is merely adding noise:
> https://www.iusmentis.com/copyright/allrightsreserved/
> 
> With BSD license, it is a historical accident of copy-and-paste; where
> different upstream sources of the license differ on whether the phrase
> is still part of the license:
> 
> https://spdx.org/licenses/BSD-2-Clause.html
> https://opensource.org/licenses/BSD-2-Clause
> 
> Thus, I can overlook it for BSD files, but I hate seeing it on GPL
> files, so I try to point it out whenever I notice it.

I agree, skip the reserved bit, otherwise it's fine.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature