This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: riscv fenv.h header file guard typo
- From: "Howland, Craig D. - US via newlib" <newlib at sourceware dot org>
- To: Newlib <newlib at sourceware dot org>
- Date: Wed, 31 Jul 2019 23:13:29 +0000
- Subject: Re: riscv fenv.h header file guard typo
- References: <CAF9ehCVdmayV2WM+7CQXWsJEuXrXdoZV8ufy_b-OwhLqVhhoZg@mail.gmail.com>
- Reply-to: "Howland, Craig D. - US" <craig dot howland at caci dot com>
________________________________________
From: newlib-owner@sourceware.org <newlib-owner@sourceware.org> on behalf of Joel Sherrill <joel@rtems.org>
Sent: Wednesday, July 31, 2019 6:47 PM
To: Newlib
Subject: riscv fenv.h header file guard typo
Hi
While working on the proposed fenv.h infrastructure support, I noticed that
the riscv fenv.h and sys/fenv.h appear to have very similar header guards
(only a trailing _ differentiates them).
/libc/machine/riscv/include/fenv.h:#ifndef _FENV_H
./libc/machine/riscv/sys/fenv.h:#ifndef _FENV_H_
Would it be better for sys/fenv.h to have _SYS_FENV_H?
--joel
Yes, better.