This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Update nwlib/libc/search directory
- From: Joel Sherrill <joel at rtems dot org>
- To: Vaibhav Gupta <vaibhavgupta40 at gmail dot com>
- Cc: Newlib <newlib at sourceware dot org>
- Date: Tue, 2 Jul 2019 10:28:20 -0500
- Subject: Re: Update nwlib/libc/search directory
- References: <CAP+cEOO2Rf6YjcM1vzafRnWAhBcU3kXEbioEkB_bTufPkaCjFQ@mail.gmail.com>
- Reply-to: joel at rtems dot org
On Tue, Jul 2, 2019 at 6:41 AM Vaibhav Gupta <vaibhavgupta40@gmail.com>
wrote:
> Hello everyone,
> I have ported ndbm.h to newlib from FreeBSD.
> I have placed ndbm.h to newlib/libc/include directory
> and
> ndbm.c to newlib/libc/posix directory .
>
> But I realized, the function declaration of __hash_open in newlib is:
> DB *__hash_open(const char *, int, int, int, const HASHINFO *);
>
> and in FreeBSD it is:
> DB *__hash_open(const char *, int, int, const HASHINFO *, int);
> .
> .
> .
> .
> Although I made required changes in ndbm.c but I guess maybe the
> entire search.h should be updated to newer FreeBSD resource?
> Should we do that?
>
I think so. It looks like previous merges have cherry picked code needed
for
ndbm support and it all needs to be updated in sync.
Out of curiosity, are the parameters all the same but the last two are in
different
order or did something more substantial change in the __hash_open signature?
--joel