Re: [PATCH] [MIPS] Fix order of eh_frame sections in linker scripts

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr 28 18:17, Faraz Shahbazker wrote:
> The compiler driver positions the linker script at the end of the linker
> command-line, after crtend.o.  As a result, any INPUT objects and archive
> GROUPs introduced by the linker script are placed after crtend.o and the
> end-of-frame marker provided by crtend.o ends up in between .eh_frames
> instead of being at the end.
> 
> This has always been a problem, but a binutils update to clean-up
> redundant NULL markers in .eh_frame exposes it as a execution failure in
> exception-handling tests.  This patch re-orders .eh_frames in all
> MIPS linker scripts so that the one from crtend.o is always placed last.
> 
> libgloss/
> 	* mips/array.ld: Re-order to place .eh_frame from crtend.o
> 	after all other .eh_frame sections.
> 	* mips/cfe.ld: Likewise.
> 	* mips/ddb-kseg0.ld: Likewise.
> 	* mips/ddb.ld: Likewise.
> 	* mips/dve.ld: Likewise.
> 	* mips/idt.ld: Likewise.
> 	* mips/idt32.ld: Likewise.
> 	* mips/idt64.ld: Likewise.
> 	* mips/jmr3904app.ld: Likewise.
> 	* mips/lsi.ld: Likewise.
> 	* mips/mti32.ld: Likewise.
> 	* mips/mti64.ld: Likewise.
> 	* mips/mti64_64.ld: Likewise.
> 	* mips/mti64_n32.ld: Likewise.
> 	* mips/nullmon.ld: Likewise.
> 	* mips/pmon.ld: Likewise.
> 	* mips/sde32.ld: Likewise.
> 	* mips/sde64.ld: Likewise.
> ---
>  libgloss/mips/array.ld      | 7 ++++++-
>  libgloss/mips/cfe.ld        | 8 +++++++-
>  libgloss/mips/ddb-kseg0.ld  | 7 ++++++-
>  libgloss/mips/ddb.ld        | 7 ++++++-
>  libgloss/mips/dve.ld        | 8 +++++++-
>  libgloss/mips/idt.ld        | 8 +++++++-
>  libgloss/mips/idt32.ld      | 7 ++++++-
>  libgloss/mips/idt64.ld      | 7 ++++++-
>  libgloss/mips/jmr3904app.ld | 7 ++++++-
>  libgloss/mips/lsi.ld        | 7 ++++++-
>  libgloss/mips/mti32.ld      | 7 ++++++-
>  libgloss/mips/mti64.ld      | 8 +++++++-
>  libgloss/mips/mti64_64.ld   | 8 +++++++-
>  libgloss/mips/mti64_n32.ld  | 8 +++++++-
>  libgloss/mips/nullmon.ld    | 8 +++++++-
>  libgloss/mips/pmon.ld       | 8 +++++++-
>  libgloss/mips/sde32.ld      | 8 +++++++-
>  libgloss/mips/sde64.ld      | 8 +++++++-
>  18 files changed, 118 insertions(+), 18 deletions(-)

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature