This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Arm] SP and SL initialization refactored


I've found a typo at the end of _stack_init routine:
+    b        lr
+    FN_END
must be
+    bx       lr
+    FN_END

I think we can fix this directly in the original patch before apply.

Alex


On Fri, Mar 29, 2019 at 10:03 PM Tamar Christina
<Tamar.Christina@arm.com> wrote:
>
> Hi Alex,
>
> I'm not that familiar with CMSIS so I'll leave that part up to Richard,
> But the rest of the patch looks good to me as well.
>
> Cheers,
> Tamar
>
> > -----Original Message-----
> > From: Nick Clifton <nickc@redhat.com>
> > Sent: Tuesday, March 26, 2019 12:43
> > To: Alexander Fedotov <alfedotov@gmail.com>; Richard Earnshaw
> > <Richard.Earnshaw@arm.com>; Tamar Christina
> > <Tamar.Christina@arm.com>; Newlib <newlib@sourceware.org>
> > Cc: nd <nd@arm.com>
> > Subject: Re: [Arm] SP and SL initialization refactored
> >
> > Hi Alex,
> >
> > > ping
> >
> > Sorry - I am not very involved with newlib these days, but I can say that the
> > changes look reasonable to me.
> >
> > Cheers
> >   Nick
> >
> >
>


--
Best regards,
AF


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]