Re: [PATCH 2/3] Move register_t to system-specific header

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb 14 19:50, Sebastian Huber wrote:
> ----- Am 14. Feb 2019 um 15:02 schrieb Corinna Vinschen vinschen@redhat.com:
> 
> > On Feb 14 11:15, Sebastian Huber wrote:
> >> 
> >> 
> >> ----- Am 13. Feb 2019 um 21:28 schrieb Corinna Vinschen vinschen@redhat.com:
> >> 
> >> > On Feb 13 20:01, Sebastian Huber wrote:
> >> >> ----- Am 13. Feb 2019 um 18:06 schrieb Corinna Vinschen vinschen@redhat.com:
> >> >> 
> >> >> > On Feb 13 14:19, Sebastian Huber wrote:
> >> [...]
> >> >> If I change the type to __intptr_t wounldn't this break ABI
> >> >> compatibility on Cygwin?
> >> > 
> >> > In how far?  Cygwin's 64 bit ABI is LP64.
> >> 
> >> The type for register_t changes from int to __intptr_to, so 32-bit to 64-bit on
> >> LP64.
> > 
> > register_t is not used in Cygwin itself.  I don't know its purpose,
> > actually.  If it has been defined as 32 bit type on 64 bit, wasn't that
> > a bug and thus unusable before?
> 
> Yes, a 32-bit register_t type on an LP64 system is a bug. It is used
> in some situations like intptr_t in FreeBSD.

Then it's ok to change it generically in just one spot.  Adding
uregister_t under BSD_VISIBLE as well.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature