This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [Aarch64] Fix _lseek prototype
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Eric Blake <eblake at redhat dot com>
- Cc: newlib at sourceware dot org
- Date: Tue, 2 Oct 2018 08:38:40 +0200
- Subject: Re: [Aarch64] Fix _lseek prototype
- References: <CAKdteObmxuMd0_m-o4f3-jWwy4+u=px_FUCRHZyE-FLwtVfMCg@mail.gmail.com> <ac776a6c-c5b0-ac4e-3c54-09b1e3e970c4@redhat.com>
On Tue, 2 Oct 2018 at 00:18, Eric Blake <eblake@redhat.com> wrote:
>
> On 10/1/18 4:35 PM, Christophe Lyon wrote:
> > Hi,
> >
> > While building newlib for Aarch64, I noticed a warning in _lseek. This
> > small patch fixes the prototype.
> >
>
> > +++ b/libgloss/aarch64/syscalls.c
> > @@ -449,6 +449,7 @@ _swilseek (int fd, int ptr, int dir)
> > return -1;
> > }
> >
> > +int
> > _lseek (int fd, int ptr, int dir)
>
> Why int and not off_t?
>
Because that's how the prototype is defined at the beginning of the same file.
Maybe time to revisit this?
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org