This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Improve sincosf comments

From: Corinna Vinschen <vinschen at redhat dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>, nd <nd at arm dot com>
Date: Thu, 16 Aug 2018 13:26:35 +0200
Subject: Re: [PATCH] Improve sincosf comments
References: <DB5PR08MB10307A877D9E9FF9B1FC2A0283240@DB5PR08MB1030.eurprd08.prod.outlook.com> <20180813073110.GA3747@calimero.vinschen.de> <DB5PR08MB10304EEEBA4BAE9C074D10A8833F0@DB5PR08MB1030.eurprd08.prod.outlook.com>
Reply-to: newlib at sourceware dot org

On Aug 16 10:39, Wilco Dijkstra wrote:
> Corinna Vinschen wrote:
>   
> > Patch is ok, but we can really drop the CVS-style ChangeLogs now.  A
> > nice explanation of the changes would be more helpful, including a word
> > on the name change pi64 -> pi63.
> 
> That is good news! How about the following:
> 
> 
> Improve comments in sincosf implementation to make the code easier
> to understand.  Rename the constant pi64 to pi63 since it's actually 
> PI * 2^-63.  Add comments for fields of sincos_t structure.  Add comments
> describing implementation details to reduce_fast.

Pushed, thanks!


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH] Improve sincosf comments
  - From: Wilco Dijkstra
- Re: [PATCH] Improve sincosf comments
  - From: Corinna Vinschen
- Re: [PATCH] Improve sincosf comments
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]