Re: libm -fno-builtin

[Corinna Vinschen <vinschen at redhat dot com>]

On Jun 25 13:31, Corinna Vinschen wrote:
> On Jun 22 10:43, Jon Beniston wrote:
> > > Care to provide a git format-patch created patch, please?
> > 
> > Here's an updated patch to remove -fno-builtin for all targets,
> > hopefully in the correct format.
> 
> Well, not quite.  Either just send the below mail file with
> `git send-email', or attach the file.  Both methods allow the
> maintainers to just use the mail or the attachment as is, rather
> than having to edit it before applying.


Uhm... even more importantly, your patch is changing the configure files
directly, rather than changing the configure.in files the configure
files are generated from.  Your below patch would be overwritten next
time the configure files are regenerated from their configure.in source
files.

For the patch, just change the configure.in files and send the below
manual configure changes alongside.  The patch is easy enough to go
without actually jumping throught the autoconf hoop.


Corinna

> > Cheers,
> > Jon
> > 
> > 
> > From: Jon Beniston <jon@beniston.com>
> > Date: Fri, 22 Jun 2018 10:39:39 +0100
> > Subject: [PATCH 1/1] Remove -fno-builtin to allow gcc to inline functions such
> >  as fabs, floor, creal, imag.
> > 
> > ---
> >  newlib/libm/configure                 | 2 +-
> >  newlib/libm/machine/aarch64/configure | 2 +-
> >  newlib/libm/machine/arm/configure     | 2 +-
> >  newlib/libm/machine/configure         | 2 +-
> >  newlib/libm/machine/i386/configure    | 2 +-
> >  newlib/libm/machine/nds32/configure   | 2 +-
> >  newlib/libm/machine/riscv/configure   | 2 +-
> >  newlib/libm/machine/spu/configure     | 2 +-
> >  8 files changed, 8 insertions(+), 8 deletions(-)
> > 
> > diff --git a/newlib/libm/configure b/newlib/libm/configure
> > index 42d503640..657ca3c24 100755
> > --- a/newlib/libm/configure
> > +++ b/newlib/libm/configure
> > @@ -3725,7 +3725,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/aarch64/configure b/newlib/libm/machine/aarch64/configure
> > index 397abd875..1ce90bcd2 100755
> > --- a/newlib/libm/machine/aarch64/configure
> > +++ b/newlib/libm/machine/aarch64/configure
> > @@ -3335,7 +3335,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/arm/configure b/newlib/libm/machine/arm/configure
> > index 397abd875..1ce90bcd2 100755
> > --- a/newlib/libm/machine/arm/configure
> > +++ b/newlib/libm/machine/arm/configure
> > @@ -3335,7 +3335,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/configure b/newlib/libm/machine/configure
> > index 2c237a126..a8255e0d4 100755
> > --- a/newlib/libm/machine/configure
> > +++ b/newlib/libm/machine/configure
> > @@ -3671,7 +3671,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/i386/configure b/newlib/libm/machine/i386/configure
> > index 0d5fae926..7fea03b2f 100755
> > --- a/newlib/libm/machine/i386/configure
> > +++ b/newlib/libm/machine/i386/configure
> > @@ -3661,7 +3661,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/nds32/configure b/newlib/libm/machine/nds32/configure
> > index 43ea30a59..04214e714 100644
> > --- a/newlib/libm/machine/nds32/configure
> > +++ b/newlib/libm/machine/nds32/configure
> > @@ -3358,7 +3358,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/riscv/configure b/newlib/libm/machine/riscv/configure
> > index 397abd875..1ce90bcd2 100755
> > --- a/newlib/libm/machine/riscv/configure
> > +++ b/newlib/libm/machine/riscv/configure
> > @@ -3335,7 +3335,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > diff --git a/newlib/libm/machine/spu/configure b/newlib/libm/machine/spu/configure
> > index 397abd875..1ce90bcd2 100644
> > --- a/newlib/libm/machine/spu/configure
> > +++ b/newlib/libm/machine/spu/configure
> > @@ -3335,7 +3335,7 @@ fi
> >  
> >  . ${newlib_basedir}/configure.host
> >  
> > -newlib_cflags="${newlib_cflags} -fno-builtin"
> > +newlib_cflags="${newlib_cflags}"
> >  
> >  NEWLIB_CFLAGS=${newlib_cflags}
> >  
> > -- 
> > 2.15.1
> > 
> 
> -- 
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat



-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature