Re: [PATCH] Improve performance of sinf/cosf/sincosf

[Corinna Vinschen <vinschen at redhat dot com>]

On Jun 18 17:59, Wilco Dijkstra wrote:
> Corinna Vinschen wrote:
> > I tested this patch on Cygwin and it breaks the build:
> >
> > ld: Cannot export cosf: symbol not defined
> > ld: Cannot export sinf: symbol not defined
> > x86_64-pc-cygwin/newlib/libm/libm.a(lib_a-ccosf.o): In function `ccosf':
> > newlib/libm/complex/ccosf.c:46: undefined reference to `sinf'
> > newlib/libm/complex/ccosf.c:46:(.text+0x6e): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `sinf'
> > newlib/libm/complex/ccosf.c:46: undefined reference to `cosf'
> 
> Yes it seems the problem was trying to use the same file names in different
> math directories, somehow that doesn't work. I've changed the files back to
> their original names, and the sinf and cosf symbols now exist.
> Here is the v2 patch:

Thanks, this builds on Cygwin again.

Could anybody with non-arm targets give it a try, too,, please?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature