This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/6] generated character data for libc/ctype


Am 26.03.2018 um 10:01 schrieb Corinna Vinschen:
On Mar 25 11:02, Thomas Wolff wrote:
Am 23.03.2018 um 22:02 schrieb Thomas Wolff:
Am 23.03.2018 um 20:43 schrieb Corinna Vinschen:
On Mar 23 20:28, Thomas Wolff wrote:
While meditating, I noticed that the bit packing of the case conversion
entries could use some documentation.
The attached patch adds that (and some tweaking for consistent
indentation);
no code changes.
Thomas
  From f8f4784437d319ad3ac2e3c629335fd0f50bee69 Mon Sep 17 00:00:00 2001
From: Thomas Wolff <towo@towo.net>
Date: Fri, 23 Mar 2018 20:07:22 +0100
Subject: [PATCH] comments to document struct caseconv_entry

explain design of compact (packed) struct caseconv_entry,
in case it needs to be modified for future Unicode versions
...
... we can reduce the patch to the documentation, of course.
as attached
Thomas
Thanks, but the patch is broken.  The last line in the patch is the
start of another patch hunk, which then is missing.  Can you fix that, please?
Yeah, I tried to limit git fiddling effort by manually manipulating the patch, which failed. (After I tried to re-sync with the current repository, it would insist on some merging, and I do not know how to rectify that; manual fixing of the file, git pull -f... nothing helped (error: Pulling is not possible because you have unmerged files); I know I should eventually consult the howto you kindly pointed me to...) So, based on a fresh git clone, here's an updated patch, also fixing one remaining minor layout glitch.
Thomas

Attachment: 0001-comments-to-document-struct-caseconv_entry.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]