Re: [PATCH] implicit Unicode data tables generation

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 13 19:24, Thomas Wolff wrote:
> Am 13.03.2018 um 16:43 schrieb Corinna Vinschen:
> > You can also never make assumptions about the age of a file provided by
> > your build OS.  There's a good chance the OS is providing an older
> > Unicode data file version than the one you actually want to build the
> > dependent files from.  Worst case, older than the currently supported
> > Unicode version.
> > 
> > The bottom line is, the Unicode data file has been either downloaded into
> > the expected location in libc/ctype, or it's not available.
> > 
> > > > The explicit rules add a rule to download the Unicode.txt file into the
> > > > src tree.  That's the only file we may rely on.  If it doesn't exist,
> > > > an implicit rule should not break the build.
> > > Well, my mentioned patch wouldn't break it anymore.
> Actually it was broken and would still abort if unicode-ucd isn't installed.
> And the contributed version of string/mkunidata is broken, too; it does
> nothing because it contains an "exit" as a test artefact.
> Sorry for this embarassing incident.

Ok, that's fine, I pushed the patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature