Re: [PATCH 3/6] generated character data for libc/ctype

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar  8 00:20, Thomas Wolff wrote:
> 

> From 15999d30c011be9041821456d23807249981dd86 Mon Sep 17 00:00:00 2001
> From: Thomas Wolff <towo@towo.net>
> Date: Sun, 25 Feb 2018 17:11:44 +0100
> Subject: [PATCH 3/6] remove hard-coded character data

Sorry, but no.  I like the idea of this and the followup patch in that
you call, e.g., iswalpha_l from iswalpha, rather than vice versa as
today.  However, don't delete and re-introduce files, just overwrite
them with the new code, for sake of a sane history.

Also, these two patches(*) should get a descriptive text in the git log.
Especially the fact that it turns around the calling order is worth a
couple of words.


Thanks,
Corinna

(*) ...which should actually be only one as outlined above.  The
    easiest way to accomplish that is probably an interactive rebase
    with squashing the second patch into the first.

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature