This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] width data generation script


Am 27.02.2018 um 16:03 schrieb Corinna Vinschen:
On Feb 26 22:40, Thomas Wolff wrote:
 From 5a7793cb8788ca4a1624f2a8af9d723b0edc6ab4 Mon Sep 17 00:00:00 2001
From: Thomas Wolff <towo@towo.net>
Date: Sun, 25 Feb 2018 16:26:48 +0100
Subject: [PATCH 3/3] width data generation script
This patch, too, should explain in a few sentences why and how we're
switching to generated data in the commit message.
Do you want the description in all 3 commits of the patch series, the main or the first of them?

Other than that, the patches look ok to me, provided the integration
of generating the data into Makefile.am / Makefile.in is forthcoming.
I am not familiar with these makefile prototype formats and their workflow.
If I can just copy the respective makefile parts verbatim into Makefile.am, that's OK, otherwise I'm asking for support. Also I have no idea how you'd like the generation to be invoked, e.g. `make data` in the ctype source directory, the libc source directory, a target directory, whatever. Please state your preference.

Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]