Re: [PATCH] locale modifier @cjkwide

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Thomas,

On Feb 26 22:42, Thomas Wolff wrote:
> I wrote yesterday:
> > It had been discussed how to reflect ambiguous character widths in
> > cygwin locales, with the result of an implicit wide property assumed for
> > the CJK locales, and an overriding @cjknarrow modifier:
> > https://sourceware.org/ml/cygwin/2009-06/msg00240.html
> > https://sourceware.org/ml/cygwin/2009-06/msg00521.html
> > https://sourceware.org/ml/cygwin/2009-06/msg00616.html
> > 
> > Now I’m getting occasional complaints about mintty support for wide
> > display of certain symbol characters, particularly as used for some
> > fancy “Powerline” add-on, and it seems that other terminals apply
> > “ambiguous wide mode” (e.g. xterm -cjk_width) in order to enable
> > Powerline.
> > While mintty has an option Charwidth=ambig-wide meanwhile, using this
> > option clearly has the drawback that it makes character width handling
> > inconsistent with the locale model as used by wcwidth.
> > Actually for mintty, the desired behaviour can be achieved in a
> > locale-consistent way by selecting one of the CJK locales for LC_CTYPE;
> > that’s not what most people would expect, however, and if they do it the
> > easy way, using LANG or LC_ALL, they are baffled by also getting
> > their message language obscured.
> > So I would prefer the option to use ambiguous wide mode in combination
> > with non-CJK locales in a locale-compatible way.
> 
> So I suggest to revisit the proposal of another generic modifier, also for
> symmetry, which is @cjkwide applicable to non-CJK locales.
> Patch attached.
> Thomas

Just one point:

> From 12b87350eb70c83cd654eec37dae3773bf58d231 Mon Sep 17 00:00:00 2001
> From: Thomas Wolff <towo@towo.net>
> Date: Sun, 25 Feb 2018 16:27:33 +0100
> Subject: [PATCH] locale modifier @cjkwide

It would be most helpful to get a v2 patch with a commit message
describing why adding cjkwide makes sense, for later reference.
The subject "locale modifier @cjkwide" is rather terse.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature