Re: [PATCH][STEP1]Remove direct access to locale structures

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb  9 10:05, Jaap de Wolff wrote:
> Hi all,
> 
>  
> 
> With this patch I move the usage of the locale structures from all files in
> folders outside ctype and locale to macros in setlocale.h 
> 
> This is the first step to prepare for removing all locale structures 

Patch is broken, excess emtpy lines, wrong line breaks.
git format-patch / git send-email?

> +#define loc_get_decimalpoint(loc) (__localeconv_l(loc))->decimal_point

Skip the "get".

> +#define loc_wctomb(loc,r,buff,wc,ps) (loc)->wctomb(r,buff,wc,ps)
> 
> +#define cur_loc_wctomb __get_current_locale ()->wctomb
> 
> +#define cur_loc_mbtowc __get_current_locale ()->mbtowc

Please use "locale" rather than "loc" and add leading underscores
to make very sure this is internal only.

> -#define __WCTOMB (__get_current_locale ()->wctomb)
> 
> +#define __WCTOMB ( cur_loc_wctomb )

Why?  Why not just redefine __WCTOMB and __MBTOWC to use the correct
expression for small/large targets.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature