Re: nano printf + powerpc gcc

[Eric Blake <eblake at redhat dot com>]

On 01/29/2018 05:56 AM, Jon Beniston wrote:
> Hi,
> 
> Is this patch what is recommended? Seems to fix it for me (but only very briefly tested on my target).

> @@ -485,6 +475,7 @@ _VFPRINTF_R (struct _reent *data,
>    register char *cp;	/* Handy char pointer (short term usage).  */
>    const char *flag_chars;
>    struct _prt_data_t prt_data;	/* All data for decoding format string.  */
> +  va_list ap_copy;
>  
>    /* Output function pointer.  */
>    int (*pfunc)(struct _reent *, FILE *, const char *, size_t len);
> @@ -522,6 +513,8 @@ _VFPRINTF_R (struct _reent *data,
>    prt_data.blank = ' ';
>    prt_data.zero = '0';
>  
> +  va_copy (ap_copy, ap);
> +
>    /* Scan the format for conversions (`%' character).  */
>    for (;;)
>      {
> @@ -577,7 +570,7 @@ _VFPRINTF_R (struct _reent *data,
>  	   *	-- ANSI X3J11
>  	   * They don't exclude field widths read from args.
>  	   */
> -	  prt_data.width = GET_ARG (n, ap, int);
> +	  prt_data.width = GET_ARG (n, ap_copy, int);
...
>  	  else
> -	    {
> -	      n = _printf_float (data, &prt_data, fp, pfunc, va_ptr(ap));
> -	    }
> +            n = _printf_float (data, &prt_data, fp, pfunc, &ap_copy);

Maybe a comment why the copy is needed is still in order, but yes, this
matches what I was thinking.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature