Re: newlib-3.0.0 yearly snapshot created

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Orlando,

thanks for catching, but could you please send the patch in
`git format-patch' format?


Thanks,
Corinna


On Jan 19 11:12, Orlando Arias wrote:
> On 01/18/2018 01:39 PM, Jeff Johnston wrote:
> > I have bumped up the newlib release to 3.0.0 with the ansification changes
> > just checked in and created the overdue yearly snapshot: newlib-3.0.0.tar.gz
> > 
> > Thanks to those who contributed and special thanks to Corinna for reviewing
> > it all.
> > 
> > -- Jeff J.
> > 
> 
> Greetings,
> 
> First, I would like to thank the maintainers and contributors for their
> work on newlib. That being said, the new snapshot fails to compile if
> --enable-lite-exit is passed to the configure script. The issue stems
> from a syntax error that was introduced in commit
> 
> --- a/newlib/libc/stdlib/exit.c
> +++ b/newlib/libc/stdlib/exit.c
> @@ -55,7 +55,7 @@ _DEFUN (exit, (code),
>  {
>  #ifdef _LITE_EXIT
>    /* Refer to comments in __atexit.c for more details of lite exit.  */
> -  void __call_exitprocs _PARAMS ((int, _PTR)) __attribute__((weak));
> +  void __call_exitprocs (int, _PTR)) __attribute__((weak);
>    if (__call_exitprocs)
>  #endif
>      __call_exitprocs (code, NULL);
> 
> I am attaching a patch that fixes this issue. Is it possible to have a
> new snapshot made with the fix?
> 
> Thank you.
> 
> Cheers,
> Orlando.

> diff --git a/newlib/libc/stdlib/exit.c b/newlib/libc/stdlib/exit.c
> index 95108ade6..7e5a5518b 100644
> --- a/newlib/libc/stdlib/exit.c
> +++ b/newlib/libc/stdlib/exit.c
> @@ -54,7 +54,7 @@ exit (int code)
>  {
>  #ifdef _LITE_EXIT
>    /* Refer to comments in __atexit.c for more details of lite exit.  */
> -  void __call_exitprocs (int, void *)) __attribute__((weak);
> +  void __call_exitprocs (int, void *) __attribute__((weak));
>    if (__call_exitprocs)
>  #endif
>      __call_exitprocs (code, NULL);





-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature