Re: [PATCH v1] Newlib ANSI-fication

[Eric Blake <eblake at redhat dot com>]

On 12/04/2017 02:56 AM, Yaakov Selkowitz wrote:
> The patches are too big at the moment to send to the list, so I pushed
> them to the topic/ansification branch for now.
> 
> Yaakov Selkowitz (15):
>   ansification: remove _AND
>   ansification: remove _CONST
>   ansification: remove _DOTS
>   ansification: remove _NOARGS
>   ansification: remove _PARAMS
>   ansification: remove _VOID_PTR
>   ansification: remove _PTR
>   ansification: remove _CAST_VOID
>   ansification: remove _DEFUN_VOID
>   ansification: remove _VOID
>   ansification: remove _VOLATILE, _SIGNED
>   ansification: remove _DEFUN
>   ansification: remove _EXFNPTR, _EXPARM
>   ansification: remove _EXFUN, _EXFUN_NOTHROW
>   ansification: remove _HAVE_STDC
> 

Just taking a glance at some of them, you include gems such as:

+++ b/libgloss/cr16/isatty.c
@@ -17,7 +17,7 @@
 /*
  * isatty -- returns 1 if connected to a terminal device,
  *           returns 0 if not. Since we're hooked up to a
- *           serial port, we'll say yes _AND return a 1.
+ *           serial port, we'll say yes and return a 1.

I'm all for this sort of cleanup!

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature