Re: [PATCH] for newlib/libc/strnstr.c newlib/libm/complex/cargl.c

[Yaakov Selkowitz <yselkowitz at cygwin dot com>]

On 2017-09-13 17:08, Yaakov Selkowitz wrote:
> On 2017-09-13 17:00, Yaakov Selkowitz wrote:
>> On 2017-09-13 13:56, Brian Inglis wrote:
>>> On 2017-09-12 14:18, Yaakov Selkowitz wrote:
>>>> Recent additions to newlib have caused some warnings:
>>>>
>>>> newlib/libc/string/strnstr.c:47:15: warning: implicit declaration of
>>>> function ‘memmem’ [-Wimplicit-function-declaration]
>>>> newlib/libm/complex/cargl.c:16:25: warning: implicit declaration of
>>>> function ‘imag’ [-Wimplicit-function-declaration]
>>>> newlib/libm/complex/cargl.c:16:35: warning: implicit declaration of
>>>> function ‘real’ [-Wimplicit-function-declaration]
>>>
>>> Patches attached, with your build fixes, fix recent build problems.
>>
>> Thanks.  In patch 1:
>>
>>>  #undef __STRICT_ANSI__
>>> +#define _GNU_SOURCE
>>>  #include <_ansi.h>
>>>  #include <string.h>
>>
>> The #undef __STRICT_ANSI__ can be removed at the same time, as #define
>> _GNU_SOURCE essentially overrides it anyway.
> 
> I just noticed Sebastian's patch, which does do this and also includes
> documentation fixes.  I'm inclined to go with his patch for strnstr and
> yours for cargl.
> 
>> Patch 2 LGTM.

In Corinna's absence, can someone ack Sebastian's patch and Brian's
second patch?

-- 
Yaakov

Attachment: signature.asc
Description: OpenPGP digital signature